Ensure correct type of event.element #5926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cast around a
event.element
, the event being aol.Collection.Event
.I don't know why, but when I use Closure-util, the line returns an error:
The native build within ol3 works fine with or without casting the type of element. I don't understand what's going on as I use the exact same configuration for the build. Also, why only this line? If you look just above, there are other places where
event.element
are used without casting the element and that works just fine. This one is picky, so this PR fixes this. It doesn't impact anyting from the actual code, just making Closure-util stop complaining about it.Ready for review.