Use tile image dimensions in rendering #5999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers sometimes return tiles that do not match the tile size specification (e.g. it can return a 1x1 blank tile where there's no data). This can cause an out-of-bound error in drawImage.
|
I am not sure why the test fails - it does happen on my box and on Travis so probably something to look into. |
|
You need to account for gutter and different device pixel ratio and source pixel ratio combinations. |
|
Since the dom renderer is removed in 3.19.0 (which isn't a bad thing, because canvas fells better performing and also the rendering when zooming seems a lot better), it would be great to have this one fixed for IE 10 + 11 and Edge. |
|
Deprecated by #6082. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers sometimes return tiles that do not match the tile size
specification (e.g. it can return a 1x1 blank tile where there's no
data). This can cause an out-of-bound error in drawImage - at least in ie 10+11.
See the discussion in #5936, this patch stems from the comment by @tschaub.