Generate projection transform function only when requested #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchandelle
force-pushed
the
projection-perf
branch
from
8133478
to
c898cda
Compare
tchandelle
commented
Nov 28, 2016
| transform = transforms[sourceCode][destinationCode]; | ||
| } | ||
| } else { | ||
| transform = undefined; |
There was a problem hiding this comment.
If I don't do that here, the builder complains, but I can't figure out why. I'd be interested if someone has an logical explanation.
|
@tchandelle I took the liberty to simplify the code a bit, which also made the compiler happy. I don't have a logical explanation though, other than that I don't like the compiler, but have learned how to make it behave by trial and error. |
|
Thanks @ahocevar, it looks better that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6174