Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offscreen canvas example does not work in production mode #12317

Closed
MoonE opened this issue May 13, 2021 · 2 comments · Fixed by #12338
Closed

Offscreen canvas example does not work in production mode #12317

MoonE opened this issue May 13, 2021 · 2 comments · Fixed by #12338
Labels

Comments

@MoonE
Copy link
Contributor

MoonE commented May 13, 2021

Describe the bug
There seem to be different minifications for the projection class with the webworker and normal example code.
These two objects cannot be compared:
image

It's caused by the changes to the example webpack config in #12176

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://deploy-preview-12313--ol-site.netlify.app/examples/offscreen-canvas.html
  2. See the failed assertion
  3. Go to the previous stack frame, as in the picture above

Expected behavior
The projections compared here should be equivalent.

@MoonE MoonE added the bug label May 13, 2021
@tschaub
Copy link
Member

tschaub commented May 14, 2021

I wonder if it would be enough to add a pattern for offscreen-canvas to the list of examples to exclude from minification.

@MoonE
Copy link
Contributor Author

MoonE commented May 14, 2021

I'm also getting an error for the raster example. color-manipulation and region-growing seem to work.
Adding offscreen-canvas / offscreen-canvs\.worker to the regex doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants