Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate reprojection tile ranges for each world #15825

Merged
merged 4 commits into from
May 15, 2024

Conversation

mike-000
Copy link
Contributor

@mike-000 mike-000 commented May 14, 2024

Fixes #15824
Fixes #15804

Added rendering tests for ImageTile based on failing example in #15824 and for DataTile based on tile grid used in #15804,

Copy link

📦 Preview the website for this branch here: https://deploy-preview-15825--ol-site.netlify.app/.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000. The code looks good, I only added a few syntactic simplification suggestions.

src/ol/reproj/DataTile.js Outdated Show resolved Hide resolved
src/ol/reproj/DataTile.js Outdated Show resolved Hide resolved
src/ol/reproj/Tile.js Outdated Show resolved Hide resolved
src/ol/reproj/Tile.js Outdated Show resolved Hide resolved
mike-000 and others added 3 commits May 15, 2024 10:09
add ImageTile test

Co-Authored-By: Andreas Hocevar <andreas.hocevar@gmail.com>
add DataTile test

Co-Authored-By: Andreas Hocevar <andreas.hocevar@gmail.com>
@mike-000 mike-000 marked this pull request as ready for review May 15, 2024 09:15
Copy link
Member

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000

@tschaub tschaub merged commit c362864 into openlayers:main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reprojection issues with wrapX: false Missing tiles in WebGLTileLayer with a GeoTiff source
3 participants