Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ol3 and ClojureScript #2069

Closed
jeluard opened this issue May 14, 2014 · 6 comments
Closed

Ol3 and ClojureScript #2069

jeluard opened this issue May 14, 2014 · 6 comments

Comments

@jeluard
Copy link

jeluard commented May 14, 2014

I have been working on a package to ease ol3 integration with ClojureScript build tools.

ClojureScript toolchain relies on closure compiler making ol3 very well suited for ClojureScript.

I encountered 2 issues with ol3's externs files and I am not sure if it's due to some ClojureScript limitation:

Are those expected?

Also please let me know if you are ok with that kind of redistribution.

@twpayne
Copy link
Contributor

twpayne commented May 14, 2014

NaN should be recognised (it's valid JS), but that said the webgl-debug.js externs file is no longer used and can be removed. @fredj can probably comment on bootstrap.js.

@fredj
Copy link
Member

fredj commented May 14, 2014

bootstrap.js depends on the jquery extern provided by closure-compiler.
Note that this extern is only used to compile the examples

@jeluard
Copy link
Author

jeluard commented May 14, 2014

Great! I will remove both from my package then.

Any issue with this project redistributing OpenLayers files?
I added your license file, let me know if you need something more.

@fredj
Copy link
Member

fredj commented May 14, 2014

If you don't use the example (it's the case by browsing your repository) you can safely remove this extern.

@elemoine
Copy link
Member

Any issue with this project redistributing OpenLayers files?
I added your license file, let me know if you need something more.

You're fine.

@jeluard
Copy link
Author

jeluard commented May 14, 2014

Great! Thanks for the fast feedback.

@jeluard jeluard closed this as completed May 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants