Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] ol.Object inconsistency: #getProperties() vs. #setValues() #2240

Closed
ahocevar opened this issue Jun 24, 2014 · 8 comments · Fixed by #2265
Closed

[API] ol.Object inconsistency: #getProperties() vs. #setValues() #2240

ahocevar opened this issue Jun 24, 2014 · 8 comments · Fixed by #2265
Assignees

Comments

@ahocevar
Copy link
Member

I think ol.Object#setValues() should be renamed to ol.Object#setProperties(). Opinions?

@ahocevar ahocevar added this to the v3.0.0 milestone Jun 24, 2014
@bartvde
Copy link
Member

bartvde commented Jun 24, 2014

or getProperties should be renamed to getValues?

@bartvde
Copy link
Member

bartvde commented Jun 24, 2014

as an aside, searching for ol.Object in the API docs is kind of painful now since there is this long list of classes descending from ol.Object that show up first, but maybe this is ticketed already somewhere

@ahocevar
Copy link
Member Author

or getProperties should be renamed to getValues?

That would be confusing with getKeys being in place, in my opinion at least.

@bartvde
Copy link
Member

bartvde commented Jun 24, 2014

for reference the Google Maps MVCObject https://developers.google.com/maps/documentation/javascript/reference?csw=1#MVCObject

there is no getProperties method, just get.
setValues is there.

@fredj
Copy link
Member

fredj commented Jun 24, 2014

That would be confusing with getKeys being in place, in my opinion at least.

Yes. getKeys returns an array of string but getProperties an object

@elemoine
Copy link
Member

+1 for getProperties and setProperties.

@ahocevar ahocevar modified the milestones: v3.0.0-gamma.2, v3.0.0 Jun 26, 2014
@marcjansen
Copy link
Member

+1 for getProperties and setProperties.

@elemoine elemoine self-assigned this Jun 27, 2014
@elemoine
Copy link
Member

I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants