Add pixel/coordinate to ol.SelectEvent

[probins]

If pixel and/or coordinate were available in SelectEvent, the code for creating popups/overlays for features such as in the vector-layer example could simply use the select interaction instead of creating its own FeatureOverlay. It looks pretty straightforward to change SelectEvent to pass these vars on from the MapBrowserEvent and I was in the middle of creating a PR when it struck me it might be better/simpler to change ol.SelectEvent so it inherits from ol.MapBrowserEvent instead of goog.events.event. Would there be any problems/issues with doing this?

[bjornharrtell]

PR #3454 might be relevant.

[probins]

thanks @bjornharrtell I managed to miss that one, which is also on my list. What do you think about adding pixel in that PR? Or would it be better in a separate one?

[bjornharrtell]

Perhaps it's better to make it a separate one and I'd like to see the tests in #3453 in first.

[bjornharrtell]

Was just hit by goog.events.event not being enough similar to you case, so I don't want to wait for #3453 (but please review it too if possible) and will make a PR to change base to ol.MapBrowserEvent.

[bjornharrtell]

@probins #3757 ready for review.

[probins]

thanks for tackling this - we're obviously trying to do similar things in our apps :-)

[ahocevar]

Fixed with #3757.