Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bane focus is tagged with Might #26

Closed
istabosz opened this issue Aug 2, 2016 · 4 comments
Closed

Bane focus is tagged with Might #26

istabosz opened this issue Aug 2, 2016 · 4 comments

Comments

@istabosz
Copy link
Collaborator

istabosz commented Aug 2, 2016

Don't know too much about github code, but this doesn't seem quite right to me.

"Might" is listed as the only attribute in the tags for Bane Focus. I'm assuming the tags should include either all of the attributes or none of them.

@brianfeister
Copy link
Member

"Tags" are a whole mess we haven't gotten into yet. Right now they do nothing, in the future I will have to do lots of work and find a way to add filters in the searchable list. The idea is that you can specifically look up "feat chains", "non-combat" feats, "combat" feats, and other ways of categorizing or grouping feats besides just their attribute prerequisite.

So that area is often wrong or a wasteland but doesn't impact anything yet

@istabosz
Copy link
Collaborator Author

istabosz commented Aug 4, 2016

K. So, should I just ignore them for now?

@brianfeister
Copy link
Member

Yeah, I mean feel free to just make them match whatever very rough approximation of a pattern you see elsewhere.

@istabosz
Copy link
Collaborator Author

istabosz commented Aug 7, 2016

10-4

@istabosz istabosz closed this as completed Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants