Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsf-2.2 added to feature list even though jsfContainer-2.2 is already specified #4

Closed
realModusOperandi opened this issue Sep 22, 2017 · 3 comments
Assignees

Comments

@realModusOperandi
Copy link
Contributor

realModusOperandi commented Sep 22, 2017

If an application which contains imports of any class under javax.faces.* is added to a Liberty server, <feature>jsf-2.2</feature> is automatically added to the feature list in server.xml. This is sensible when an application uses JSF but no feature which provides it is present in server.xml.

However, jsfContainer-2.2 is a feature which allows applications to provide their own implementation of the JSF specification while still using the specification interfaces. If jsfContainer-2.2 is already specified, It isn't ideal behavior to also enable jsf-2.2, since that would enable the implementation provided by the runtime, which I don't want. This is the current behavior.

If jsfContainer-2.2 is already specified, The jsfContainer implementers and I think the jsf-2.2 feature shouldn't be added automatically. Thoughts?

@realModusOperandi realModusOperandi self-assigned this Sep 22, 2017
@realModusOperandi
Copy link
Contributor Author

I'll make a PR to illustrate what I think the behavior should be.

@realModusOperandi
Copy link
Contributor Author

realModusOperandi commented Sep 22, 2017

Hmm, looks like this accounts for the scenario where import javax.faces.* etc is used, but not for the case that no such interface is imported, but a faces-config.xml file exists. Looking...

The case where the jsf facet is enabled is also going to have to be addressed, I'd imagine.

@realModusOperandi
Copy link
Contributor Author

realModusOperandi commented Nov 13, 2017

I have found an approach which covers all situations in which jsf would be added but jsfContainer is already present: import, faces-config.xml, and facet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant