Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add features to a built-in layer #161

Open
zstadler opened this issue Mar 15, 2024 · 1 comment
Open

Document how to add features to a built-in layer #161

zstadler opened this issue Mar 15, 2024 · 1 comment

Comments

@zstadler
Copy link
Contributor

The customizing section of the README.md has an example for adding an attribute to a built-in layer.

Please add an example of adding features to a built-in layer. For example, how to add historic=memorial OSM features to the poi layer in addition to the historic=monument features it already includes.

@msbarry
Copy link
Collaborator

msbarry commented Mar 16, 2024

The only way to do this today is to modify the filters in generated Tables.java file that define which OSM elements go into each layer, so you would replace this line in OsmPoiPoint

matchAny("historic", "monument", "castle", "ruins"),

with

matchAny("historic", "monument", "castle", "ruins", "memorial"),

Eventually when the openmaptiles profile is driven primarily by config, you'd just change your copy of the config but this is the best way right now. As a step in that direction, it might make sense for the generate script to copy openmaptiles config into this repo and read it at runtime instead of generating code from it. @phanecak-maptiler what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants