Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal scattering data #14

Closed
AI-Pranto opened this issue Apr 16, 2021 · 7 comments
Closed

Thermal scattering data #14

AI-Pranto opened this issue Apr 16, 2021 · 7 comments

Comments

@AI-Pranto
Copy link

@shimwell It's really amazing I ❤️ this.

One question, How to install thermal scattering data?

@shimwell
Copy link
Contributor

Yes good question, currently it can't perform that download.

If I can map each s(a,b) thermal cross section to a particular element or elements then I can add a flag to include them or not.

Currently these are processed but not included in the database of available cross sections.

I shall look into it.

@shimwell
Copy link
Contributor

Ok i think I have a method for the command line tool

I can add a flag for -sab and accept a list of stings. Each entry must be in this list of acceptable names.

The input strings can be checked against acceptable names define here https://github.com/openmc-dev/openmc/blob/efcc0c158edcc3e389eb20a5c5ffc4e0a65ef554/openmc/data/thermal.py#L30-L77

Then the unique sab names can be match to the urls in the endf list of h5 files containing thermal cross sections (botton of this page

For the api usage I notice the openmc.material.add_s_alpha_beta sets a ._sab attribute so that can be used to check if there are sab requirments in the material object

https://github.com/openmc-dev/openmc/blob/efcc0c158edcc3e389eb20a5c5ffc4e0a65ef554/openmc/material.py#L697

Sorry this is taking me a little while as I have a few projects to close out at the moment

@shimwell shimwell mentioned this issue Apr 26, 2021
5 tasks
@shimwell
Copy link
Contributor

shimwell commented Apr 28, 2021

@AI-Pranto I have had a go at adding this feature in the latest PR merge #16 there are a few examples on the readme.

The pip install on PyPi has also been updated to v0.3.0 https://pypi.org/project/openmc-data-downloader/#history

I am keen to improve it if you have any suggestions

@AI-Pranto
Copy link
Author

Sorry for the late response here.

LGTM, Thanks @shimwell!

Just one last request here, Currently we have neutrons and Tsl data only at a single temperature 294. Can we include neutrons data at 250 K, 293.6 K, 600 K, 900 K, 1200 K, and 2500 K? We can update our current ENDF-B-VII.1-NNDC data storage by downloading pre-processed data from openmc-data Is it ok with you?
@shimwell Did you face data storage limit in github?

@shimwell
Copy link
Contributor

Yep there is a storage limit per repo so I guess that each temperature could be a separate repo to avoid that.

The repos on this organisation currently make use of these scripts to download data and process it into h5 data.

They are all templates a single repository with library specific modifications

So I would need another base repository to template that would take a different approach

The new template would download from https://openmc.org/official-data-libraries/ extract and self commit to the repo using a GitHub action

This might take a little while to sort out and then extend to do different temperatures but it is certainly now on the todo list, thanks for the suggestion

@AI-Pranto
Copy link
Author

Thanks, @shimwell :)

@AI-Pranto
Copy link
Author

Fix by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants