Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight window bounds ordering #2123

Open
pshriwise opened this issue Jul 18, 2022 · 0 comments
Open

Weight window bounds ordering #2123

pshriwise opened this issue Jul 18, 2022 · 0 comments

Comments

@pshriwise
Copy link
Contributor

The ordering of weight window values is a little confusing right now. We currently accept an arbitrarily shaped ndarray and assume its ordering is the number of mesh elements in each dimension followed by the number of energy groups: nx, ny, nz, ne (listed from changing fastest to changing slowest). This is very easy to get incorrect however and detecting errors in the ordering is diffucult.

I'll propose here that we:

  1. Enforce the shape of the lower_ww_bounds/upper_ww_bounds attributes to be (nx, ny, nz, ne). (If a flat array/iterable is passed in, reshape it ourselves and provide a warning). We'll then write out the flat array as proposed in Make sure weight window lower/upper bounds are flattened before writing to XML #2113.
  2. Document this more clearly on the WeightWindow class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant