Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Time Machine quota setting #910

Closed
ishioni opened this issue Jan 1, 2021 · 4 comments
Closed

Implement Time Machine quota setting #910

ishioni opened this issue Jan 1, 2021 · 4 comments

Comments

@ishioni
Copy link

ishioni commented Jan 1, 2021

Is your feature request related to a problem? Please describe.
Implement time machine quota
Describe the solution you'd like
There are 2 ways to do this, dependent on samba version. For versions that implement time machine properly on vfs_fruit, it is enough to add to the share config

time machine max size = 200G

But I would discourage this, as it recalculates the share free space on every df call by the client (as seen in https://github.com/samba-team/samba/blob/master/source3/modules/vfs_fruit.c#L4985)

The better way to do this is to place a .com.apple.TimeMachine.quota.plist file in the share, with the contents

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>GlobalQuota</key>
<integer>300000000000</integer>
</dict>
</plist>

This works on MacOS 10.9 up to MacOS 11 Big Sur (can be checked by inspecting Info.plist in the sparsebundle under the com.apple.diskimage.sparsebundle key. Note that this quota works per-machine, so each machine backup gets their own quota from this limit, it is not shared.

Describe alternatives you've considered
Filesystem quotas do not work, since samba does not export them to the client (or at least MacOS doesn't recognize them)

@stale
Copy link

stale bot commented Jun 4, 2021

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.

@stale stale bot added the stale label Jun 4, 2021
@stale
Copy link

stale bot commented Sep 3, 2021

This issue has been automatically closed because there has been no activity for 90 days. We are sorry that we haven't been able to prioritize it yet. Please feel free to reopen this issue or create a new one. Thank you!

@stale stale bot closed this as completed Sep 3, 2021
@poranje
Copy link

poranje commented Nov 25, 2022

Shouldn't .com.apple.TimeMachine.quota.plist be name .com.apple.timemachine.quota.plist ?
(no capatalisation)

@edgimar
Copy link

edgimar commented Apr 29, 2023

@votdev, any chance this one might be reconsidered? It seems pretty straightforward to implement -- I am not super familiar with the OMV codebase, but if you can provide suggestions on what would need to change and how, I'm sure that I or others could attempt to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants