Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.1 Deprecation notice(s) #8

Closed
mgrundkoetter opened this issue Mar 15, 2023 · 4 comments · Fixed by #13
Closed

8.1 Deprecation notice(s) #8

mgrundkoetter opened this issue Mar 15, 2023 · 4 comments · Fixed by #13
Assignees
Milestone

Comments

@mgrundkoetter
Copy link

Expected Behavior

Should work on PHP 8.1+ :-)

Actual Behavior

Deprecated: Return type of OpenMetricsPhp\Exposition\Text\Collections\LabelCollection::getIterator(): iterable should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/openmetrics-php/exposition-text/src/Collections/LabelCollection.php on line 65

There are probably some more.

Steps to Reproduce the Problem

  1. Use lib with PHP 8.1
  2. do something with labels
  3. recognize deprecation warning

Specifications

  • Package version: 0.3.1
  • PHP version: 8.1.
  • Platform/OS: Docker
  • Subsystem: php:8.1-apache

Further comments

@m-nic
Copy link
Contributor

m-nic commented Jan 28, 2024

Hi,
Same issue is encountered on several classes for php 8.3.
Is this repo abandoned?

@hollodotme
Copy link
Member

It's not abandoned. There is just not enough time on my end at the moment. Any help - in the meaning of a Pull Request Contribution - is welcome. 🙏

@m-nic
Copy link
Contributor

m-nic commented Jan 29, 2024

It's not abandoned. There is just not enough time on my end at the moment. Any help - in the meaning of a Pull Request Contribution - is welcome. 🙏

See: #11

@hollodotme hollodotme mentioned this issue May 4, 2024
@hollodotme hollodotme added this to the v0.4.0 milestone May 4, 2024
@hollodotme
Copy link
Member

Will be fixed with #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants