Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Default ceil Functionality for Base Tensor Type #30

Closed
iamtrask opened this issue Aug 9, 2017 · 3 comments
Closed

Implement Default ceil Functionality for Base Tensor Type #30

iamtrask opened this issue Aug 9, 2017 · 3 comments
Labels
Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor

Comments

@iamtrask
Copy link
Member

iamtrask commented Aug 9, 2017

User Story A: As a Data Scientist using Syft's Base Tensor type, we want to implement a default method for computing operations on a Tensor of arbitrary type. For this ticket to be complete, ceil() should return a new tensor and ceil_() should perform the operation inline. For a reference on the operation this performs check out PyTorch's documentation.

Acceptance Criteria:

  • If the Base Tensor type's attribute "encrypted" is set to True, it should return a NotImplemented error.
  • a unit test demonstrating the correct operation on the Base Tensor type implemented over int and float Tensors.
  • inline documentation in the python code. For inspiration on inline documentation, please check out PyTorch's documentation for this operator.
@iamtrask iamtrask modified the milestone: Helium Aug 10, 2017
@iamtrask iamtrask added d. Beginner Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor labels Aug 10, 2017
@EdwardDixon
Copy link
Contributor

@siarez
Copy link
Contributor

siarez commented Sep 5, 2017

Should this be closed? @iamtrask

@iamtrask
Copy link
Member Author

iamtrask commented Sep 5, 2017

Yes! Thank you.

@iamtrask iamtrask closed this as completed Sep 5, 2017
gmuraru pushed a commit that referenced this issue Mar 5, 2021
* Add initial README

* Fix link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Development

No branches or pull requests

3 participants