Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when encrypting empty vectors #46

Closed
youben11 opened this issue May 11, 2020 · 2 comments · Fixed by #126
Closed

Throw error when encrypting empty vectors #46

youben11 opened this issue May 11, 2020 · 2 comments · Fixed by #126
Assignees
@IanQS
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint

Comments

@youben11
Copy link
Member

Current implementation allows for encrypting an empty vector, which actually doesn't make sense. We should block the user when trying to do so.
@youben11 youben11 added the Good first issue 🎓 Perfect for beginners, welcome to OpenMined! label May 11, 2020
@youben11 youben11 mentioned this issue May 11, 2020
Merged
@philomath213 philomath213 mentioned this issue Jul 7, 2020
Merged
4 tasks
@youben11 youben11 added the Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint label Jul 7, 2020
@IanQS
Copy link
Member

IanQS commented Aug 1, 2020 •
edited

Would you prefer an exception from within C++ or within Python? I'd like to take this issue on if possible :)

@youben11
Copy link
Member Author

youben11 commented Aug 1, 2020

C++ please :). All the library features should be implemented in C++, Python is just a binding and can have specific features that only apply for it

@IanQS IanQS mentioned this issue Aug 1, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanQS IanQS

Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for empty vectors upon encryption IanQS/TenSEAL
2 participants
@IanQS @youben11