Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLS Spec change] Ensure that a signature public key is always intelligible #637 #895

Closed
franziskuskiefer opened this issue May 12, 2022 · 1 comment
Assignees
Labels
mls-spec change Changes in the MLS Spec we need to implement wire-format change

Comments

@franziskuskiefer
Copy link
Contributor

franziskuskiefer commented May 12, 2022

Description of the changes
This PR moves the signature key from Credential to LeafNode, to ensure that an MLS client always has a signature public key with which to verify messages, even if it does not support a member's credential type.

This is an alternative approach to mlswg/mls-protocol#628, and IMO a bit cleaner. We no longer need the notion of a SignatureScheme, since BasicCredential doesn't stand alone. And since Credential only appears in LeafNode, common fields can be hoisted up into LeafNode. The Credential struct really only exists as a conceptual boundary, to make the exposition clearer; otherwise you could just shove the select into LeafNode.

Note that this does not obviate the need for mlswg/mls-protocol#631. This PR only ensures that the signatures can be processed; that PR helps ensure that the signatures are meaningful.

Link to the exact changes
mlswg/mls-protocol#637

@franziskuskiefer franziskuskiefer added the mls-spec change Changes in the MLS Spec we need to implement label May 12, 2022
@franziskuskiefer franziskuskiefer changed the title Ensure that a signature public key is always intelligible #637 [MLS Spec change] Ensure that a signature public key is always intelligible #637 May 12, 2022
@franziskuskiefer franziskuskiefer self-assigned this Oct 10, 2022
@franziskuskiefer
Copy link
Contributor Author

This has been addressed as part of #819 and #1222.
No changes are needed for this spec change but x509 will be implemented in #134 and address any changes introduced in this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mls-spec change Changes in the MLS Spec we need to implement wire-format change
Projects
Status: Done
Archived in project
Development

No branches or pull requests

1 participant