-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate Redundant Core Plugin Setup Steps #108
Labels
Comments
Merged
PR for this opened #114 |
PR merged |
Please address comments. https://github.com/openmobilehub/omh-storage/pull/114/files#r1283829362 |
PR for this #121 |
PR merged on branch Please let me know once the new artifacts are deployed for update the references on the code and also update the code snippet c.c.: @dzuluaga |
PR opened #123 |
Merged
PR merged |
PR opened #124 |
PR merged Task done ✅ |
Thanks. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
In the code-starter branch of our repository, we have noticed redundant setup steps for the Core plugin. Both the necessary
com.openmobilehub.android.omh-core
dependency and omhConfig setup are already included in the code. However, we also have these steps documented in the README file.Problem:
The redundancy in setup instructions may confuse users and raises the question of why we ask them to include the same dependencies manually when they are already provided in the code.
Expected Solution:
To streamline the user experience and avoid confusion, we should remove the explicit inclusion of
com.openmobilehub.android.omh-core
and omhConfig setup from the code-starter branch. Instead, users should be directed to follow the README file for the complete setup instructions, including manual dependency inclusion.The text was updated successfully, but these errors were encountered: