Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Redundant Core Plugin Setup Steps #108

Closed
dzuluaga opened this issue Jul 31, 2023 · 10 comments
Closed

Eliminate Redundant Core Plugin Setup Steps #108

dzuluaga opened this issue Jul 31, 2023 · 10 comments
Assignees
Labels
bug Something isn't working code-starter documentation Improvements or additions to documentation

Comments

@dzuluaga
Copy link
Collaborator

In the code-starter branch of our repository, we have noticed redundant setup steps for the Core plugin. Both the necessary com.openmobilehub.android.omh-core dependency and omhConfig setup are already included in the code. However, we also have these steps documented in the README file.

Problem:
The redundancy in setup instructions may confuse users and raises the question of why we ask them to include the same dependencies manually when they are already provided in the code.

Expected Solution:
To streamline the user experience and avoid confusion, we should remove the explicit inclusion of com.openmobilehub.android.omh-core and omhConfig setup from the code-starter branch. Instead, users should be directed to follow the README file for the complete setup instructions, including manual dependency inclusion.

@dzuluaga dzuluaga added bug Something isn't working documentation Improvements or additions to documentation code-starter labels Jul 31, 2023
@HectorNarvaez
Copy link
Contributor

PR for this opened #114

@HectorNarvaez
Copy link
Contributor

PR merged

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 4, 2023

@HectorNarvaez
Copy link
Contributor

PR for this #121

@HectorNarvaez
Copy link
Contributor

PR merged on branch release/1.0

Please let me know once the new artifacts are deployed for update the references on the code and also update the code snippet

c.c.: @dzuluaga

@HectorNarvaez
Copy link
Contributor

PR opened #123

@HectorNarvaez
Copy link
Contributor

PR merged

@HectorNarvaez
Copy link
Contributor

PR opened #124

@HectorNarvaez
Copy link
Contributor

PR merged

Task done ✅

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 7, 2023

Thanks. LGTM

@dzuluaga dzuluaga closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code-starter documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants