Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Code and Placeholder Comment in "storage-starter-sample" Module's build.gradle #117

Closed
dzuluaga opened this issue Aug 4, 2023 · 5 comments
Closed

Incorrect Code and Placeholder Comment in "storage-starter-sample" Module's build.gradle #117

dzuluaga opened this issue Aug 4, 2023 · 5 comments
Assignees
@nelsonwilches @HectorNarvaez
Labels
code-starter documentation Improvements or additions to documentation

Comments

@dzuluaga
Copy link
Collaborator

dzuluaga commented Aug 4, 2023

The current code in the build.gradle file for the "storage-starter-sample" module already contains the requested plugin id under the plugins element. Therefore, we need to remove the redundant line from the file and replace it with a placeholder comment.

Also, for key names use backticks instead of double quotes.
@dzuluaga dzuluaga added documentation Improvements or additions to documentation code-starter labels Aug 4, 2023
@HectorNarvaez HectorNarvaez mentioned this issue Aug 4, 2023
Merged
@HectorNarvaez
Copy link
Contributor

PR opened #126

@HectorNarvaez
Copy link
Contributor

PR merged

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 7, 2023

Thanks, Hector. Please take a look at this comment.

@HectorNarvaez HectorNarvaez mentioned this issue Aug 8, 2023
Merged
@HectorNarvaez
Copy link
Contributor

PR opened #133

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 9, 2023

LGTM. Thx

@dzuluaga dzuluaga closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonwilches nelsonwilches

@HectorNarvaez HectorNarvaez

Labels
code-starter documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dzuluaga @nelsonwilches @HectorNarvaez