-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reminder: Close FileOutputStream in handleDownloadSuccess() #119
Comments
PR opened #125 |
PR merged |
Per my last comment this change is for the sample app, not the README. Please fix it. |
PR opened #131 |
PR merged c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288 |
LGTM. Thx |
Reopening to address removing it from the README section. |
PR opened #134 |
PR merged c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288 |
LGTM. Thx |
In the handleDownloadSuccess() function, please remember to close the fileOutputStream after writing the downloaded data to a file. Proper resource management is essential for reliable and efficient code.
Suggested Solution:
To ensure proper resource management and improve the reliability of the code, we recommend adding the necessary code to close the
fileOutputStream
after thebytes.writeTo(fileOutputStream)
operation.Example Using Kotlin's
use
Function:The text was updated successfully, but these errors were encountered: