Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agency] Merge update_trip_telemetry into /event ? #207

Closed
sebdiem opened this issue Jan 9, 2019 · 3 comments
Closed

[agency] Merge update_trip_telemetry into /event ? #207

sebdiem opened this issue Jan 9, 2019 · 3 comments

Comments

@sebdiem
Copy link

sebdiem commented Jan 9, 2019

I would suggest merging the update_trip_telemetry endpoint defined in [1] into the vehicles/{id}/event endpoint.
This could be done by adding a new trip_telemetry vehicle event.
In addition the required body parameter telemetry in the vehicles/{id}/event endpoint is not specified in the spec. It's probably also worth merging with the Route type (a Route is simply an ordered list of telemetries).

What do you think about this ?

[1] https://github.com/CityOfLosAngeles/mobility-data-specification/tree/dev/agency#update_trip_telemetry

@sebdiem
Copy link
Author

sebdiem commented Jan 9, 2019

Ok, I saw the discussions on #194 .
Maybe it is indeed relevant to keep 2 separate endpoints that could be scaled differently (the telemetry endpoint is expected to receive more load obviously).
However to keep things "restish" I would rename vehicles/{id}/update_telemetry to vehicles/{id}/telemetry

@marie-x
Copy link
Collaborator

marie-x commented Jan 10, 2019

The PR is to change telemetry submission to /vehicles/telemetry. Because telemetry is expected to be > 99% of the transactions, telemetry is batched and not per-vehicle.

@sebdiem
Copy link
Author

sebdiem commented Jan 10, 2019

Oh yes indeed submission to /vehicles/telemetry/ is addressed in #196 .
Thanks.

@sebdiem sebdiem closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants