Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical_accuracy field and rename 'accuracy' to 'horizontal_accuracy' #661

Closed
quicklywilliam opened this issue Jul 22, 2021 · 1 comment · Fixed by #796
Closed

Add vertical_accuracy field and rename 'accuracy' to 'horizontal_accuracy' #661

quicklywilliam opened this issue Jul 22, 2021 · 1 comment · Fixed by #796
Labels
Agency Specific to the Agency API Provider Specific to the Provider API
Milestone

Comments

@quicklywilliam
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In #653 we chose not to add vertical accuracy to keep things consistent with the existing implementation in Agency. This issue is being filed so that in a future breaking release we can make this change in both Provider and Agency.

Describe the solution you'd like

Add new vertical_accuracy field to Geographic Telemetry Data and Agency Telemetry objects. Also, rename existing accuracy field to horizontal_accuracy.

Is this a breaking change

  • Yes, breaking

Impacted Spec

For which spec is this feature being requested?

  • agency
  • provider
@schnuerle schnuerle added Agency Specific to the Agency API Provider Specific to the Provider API labels Jul 23, 2021
@schnuerle schnuerle added this to the Future milestone Jul 23, 2021
@schnuerle schnuerle modified the milestones: Future, 2.0.0 Aug 11, 2021
@schnuerle
Copy link
Member

To be resolved with PR #796

@schnuerle schnuerle linked a pull request Jan 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Provider Specific to the Provider API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants