Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema version for 1.2.x #683

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Update schema version for 1.2.x #683

merged 3 commits into from
Sep 1, 2021

Conversation

thekaveman
Copy link
Collaborator

Explain pull request

This is a fix for the schema version bug identified in #669 targeting the forthcoming 1.2.0 release of MDS. The issue left open the possibility of a separate hotfix for the 1.1.x line (e.g. a 1.1.1 release); this PR does not address the hotfix and a separate PR would be needed. Please follow-up on the issue if you are interested.

Is this a breaking change

  • No, not breaking

Impacted Spec

  • policy
  • provider

Additional context

I also snuck in a fix to a timestamp minimum value in the policy.json schema, a follow-on from the work done and already merged in #648. I missed that when I did the review!

Important reminder for schema changes:

  1. First edit the relevant templates in the schema/ directory at the root of this repository
  2. Then run the generate_schemas.py script, also found in that directory, to regenerate the schemas from the templates
  3. Review the regenerated schema files and commit changes as necessary

@thekaveman thekaveman requested a review from a team as a code owner August 18, 2021 05:50
@thekaveman thekaveman added Schema Implications for JSON Schema or OpenAPI Policy Specific to the Policy API Provider Specific to the Provider API labels Aug 18, 2021
@thekaveman thekaveman added this to the 1.2.0 milestone Aug 18, 2021
@schnuerle schnuerle linked an issue Aug 18, 2021 that may be closed by this pull request
@schnuerle schnuerle self-assigned this Aug 18, 2021
Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I'll contact you to see about doing a patch for 1.1 as well.

@schnuerle schnuerle merged commit 0fb8a9e into openmobilityfoundation:dev Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Policy Specific to the Policy API Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version number is 1.0.x for 1.1.0 release
2 participants