Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification needed on possible values of rule_units #704

Closed
janedotx opened this issue Oct 16, 2021 · 2 comments
Closed

Clarification needed on possible values of rule_units #704

janedotx opened this issue Oct 16, 2021 · 2 comments
Labels
Policy Specific to the Policy API
Milestone

Comments

@janedotx
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In the policy README, rule_units is amount for a rate rule type, but it could be a unit of time instead if the rate rule has a recurrence of each_time_unit or per_complete_time_unit.

Describe the solution you'd like

Get rid of amount as a valid value for rule_units. There doesn't seem to be much point in having rule_units have a value of amount just for rate rules that recur only once.

Is this a breaking change

I don't think this is breaking. If you write a recurring rate rule, you already have to set rule_units to some sort of time unit to have the rule make sense in the first place.

  • No, not breaking

Impacted Spec

For which spec is this feature being requested?

  • policy

Describe alternatives you've considered

We could leave it as is, but it seems very confusing to me.

Additional context

Add any other context or screenshots about the feature request here.

@schnuerle schnuerle added the Policy Specific to the Policy API label Oct 22, 2021
@schnuerle schnuerle added this to the 2.0.0 milestone Oct 27, 2021
@schnuerle
Copy link
Member

This may be addressed as part of the Policy re-work lead by @S-eb and @jean-populus.

@jean-populus
Copy link
Collaborator

I believe rate as been removed a rule_unit with this PR #806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Policy Specific to the Policy API
Projects
None yet
Development

No branches or pull requests

3 participants