Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle software/hardware properties #705

Open
robinef opened this issue Oct 19, 2021 · 4 comments
Open

Vehicle software/hardware properties #705

robinef opened this issue Oct 19, 2021 · 4 comments
Labels
Agency Specific to the Agency API Provider Specific to the Provider API
Milestone

Comments

@robinef
Copy link

robinef commented Oct 19, 2021

Is your feature request related to a problem? Please describe.

Actually some cities are willing to understand the percentage of vehicle equipped with swappable batteries.

This information is usually related to the vehicle generation (v1,v2, etc ...)

Describe the solution you'd like

A potential solution that is non-breaking would be to add this field to the /vehicle endpoint

Is this a breaking change

  • No, not breaking

Impacted Spec

For which spec is this feature being requested?

  • provider

Describe alternatives you've considered

No other idea for now

Additional context


**Endpoint:** `/vehicles`  
**Method:** `GET`  
**[Beta feature][beta]:** Yes (as of 0.4.1)  
**Schema:** [`vehicles` schema][vehicles-schema]  
**`data` Payload:** `{ "vehicles": [] }`, an array of objects with the following structure

| Field | Type | Required/Optional | Comments |
| ----- | ---- | ----------------- | ----- |
| `generation` | string | Required | A string representing the vehicle version based on generation naming |
@schnuerle
Copy link
Member

schnuerle commented Oct 22, 2021

Is vehicle generation or version enough information here? Should there also be a vehicle model number, or maybe that instead of the version? Is it assumed all cities will know about versions/models of provider vehicles, or should other properties be included explicitly, like 'swappable_battery' or 'wheel_size' or 'basket', etc? Maybe this is part of a larger vehicle properties conversation.

@robinef
Copy link
Author

robinef commented Oct 26, 2021

Agree that it could lead to a wider discussion on the vehicle properties, but at first, if MDS can expose this version (software layer ?) and generation (hardware layer ?) and we can do the mapping externally without making things too complicated.

@schnuerle schnuerle added Agency Specific to the Agency API Provider Specific to the Provider API labels Oct 27, 2021
@schnuerle schnuerle changed the title Vehicle generation identifier Vehicle software/hardware properties Oct 27, 2021
@schnuerle schnuerle added this to the 2.0.0 milestone Oct 28, 2021
@schnuerle
Copy link
Member

schnuerle commented Oct 28, 2021

@schnuerle schnuerle modified the milestones: 2.0.0, Future Jan 9, 2023
@schnuerle
Copy link
Member

Moving to a future release which could be 2.1 since it would be a non breaking change.

@schnuerle schnuerle pinned this issue Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Provider Specific to the Provider API
Projects
None yet
Development

No branches or pull requests

2 participants