Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of description vehicle events (car sharing) #868

Closed
bergenklem opened this issue May 22, 2023 · 3 comments · Fixed by #881
Closed

Correction of description vehicle events (car sharing) #868

bergenklem opened this issue May 22, 2023 · 3 comments · Fixed by #881
Labels
bug Something isn't working Car Share Car share mode: cars, vehicles, short or long term rentals documentation documentation change can be for code and/or markdown pages minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Milestone
2.0.1

Comments

@bergenklem
Copy link
Contributor

Of what we can see, the table for [vehicle events in car sharing mode needs an update, as they right now points towards actions that are more in relation to taxi services (and/or autonomous vehicles) than a car sharing operation as of today.

event types description
@schnuerle schnuerle added bug Something isn't working documentation documentation change can be for code and/or markdown pages minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. Car Share Car share mode: cars, vehicles, short or long term rentals labels May 22, 2023
@schnuerle schnuerle added this to the 2.0.1 milestone May 30, 2023
@schnuerle
Copy link
Member

Yes this looks like just a carry over typo. So this can be fixed in the next release, maybe a 2.0.1 patch release.

@schnuerle
Copy link
Member

If you can make a PR for this change, that would be helpful, and you'd be listed as a GitHub contributor. We are looking at creating a 2.0.1 release soon for all open issues and PRs tagged with the 2.0.1 Milestone. If not I will create the PR.

@bergenklem bergenklem mentioned this issue Oct 17, 2023
Merged
@schnuerle schnuerle linked a pull request Oct 19, 2023 that will close this issue
Update to pairing list of vehicle_state and event_type for car sharing #881
Merged
@schnuerle
Copy link
Member

Closed with #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Car Share Car share mode: cars, vehicles, short or long term rentals documentation documentation change can be for code and/or markdown pages minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Projects
None yet
Milestone
2.0.1
2 participants
@schnuerle @bergenklem