Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems System.Drawing #808

Closed
MihailHavenT opened this issue Feb 14, 2024 · 2 comments · Fixed by #824
Closed

Problems System.Drawing #808

MihailHavenT opened this issue Feb 14, 2024 · 2 comments · Fixed by #824
Labels
area-UnityEngine bug Something isn't working

Comments

@MihailHavenT
Copy link

Hello, I'm experiencing issues with Rocket plugins that utilize System.Drawing. Through testing, I've observed a correlation with OpenMod. When OpenMod is removed, the specific error I've noted doesn't occur. However, upon reintroducing OpenMod, the error reappears along with the malfunction of certain plugins. I'm seeking clarification on whether this issue stems from OpenMod or another source. I eagerly await your response.

ERR SHOW

@DiFFoZ
Copy link
Member

DiFFoZ commented Feb 26, 2024

System.Web.dll is currently using System.Drawing.dll ToolboxBitmap class.
image

And we cannot remove dependency of System.Web because netstandard2.1 requires it (but only HttpUtility).

// System.Web, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
[assembly: TypeForwardedTo(typeof(global::System.Web.HttpUtility))]

The fix would be to create an System.Web shims that will include only 1 class HttpUtility.

@DiFFoZ DiFFoZ added bug Something isn't working area-UnityEngine labels Feb 26, 2024
@DiFFoZ
Copy link
Member

DiFFoZ commented Mar 9, 2024

Looks like we don't need to create a shims of System.Web. HttpUtility is already included in System.dll file!

Will try to find the correct .netstandard2.1 that points to the System lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UnityEngine bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants