Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of bright_bit is incorrect #26

Open
pvanlaet opened this issue Jan 7, 2020 · 0 comments
Open

Description of bright_bit is incorrect #26

pvanlaet opened this issue Jan 7, 2020 · 0 comments

Comments

@pvanlaet
Copy link
Contributor

pvanlaet commented Jan 7, 2020

(on portal)
Current description: "The bit that indicates the brightest part of the day. -1 when not in use."
This is not correct. Also the name is not ideal.
Better description: "The bit that indicates when the bright_offset is reached. -1 when not in use."

Improvement for "bright_offset" description: "The offset (in minutes) after sunrise and before sunset (decided by horizon_bit) on which the bright_bit should be set."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant