Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UNSUPPORTED_DATA_TYPE message in JSON output object #1269

Open
jrobble opened this issue Mar 8, 2021 · 1 comment
Open

Improve UNSUPPORTED_DATA_TYPE message in JSON output object #1269

jrobble opened this issue Mar 8, 2021 · 1 comment
Assignees
Milestone

Comments

@jrobble
Copy link
Member

jrobble commented Mar 8, 2021

End users find this message confusing:

"code": "UNSUPPORTED_DATA_TYPE",
                  "message": "The detection component does not support detection data type of UNKNOWN"

This happened when trying to process a plain text file. Users assume that OpenMPF knows what a text file is, considering that at least one component supports that MIME type.

To improve this message, mention the MIME type:

"The detection component does not support detection data type of text/plain."

@jrobble jrobble self-assigned this Mar 8, 2021
@jrobble jrobble transferred this issue from openmpf/openmpf-components Mar 8, 2021
@jrobble jrobble added this to the Milestone 1 milestone Mar 8, 2021
@jrobble jrobble moved this from To do to Planned in OpenMPF: Development Mar 8, 2021
@brosenberg42
Copy link
Member

I think we should provide more information in UNKNOWN/GENERIC case. If someone sees "The detection component does not support detection data type of application/msword." They may try to convert it to PDF, get an error, then try to convert to OpenOffice, etc.

I think we should make it say something like "The detection component does not support detection data type of GENERIC. The mime type was detected to be text/plain, which was classified as GENERIC because it isn't an image, video, or audio file. The component does not support any GENERIC media."

@jrobble jrobble modified the milestones: Milestone 1, Milestone 2 May 14, 2021
@jrobble jrobble modified the milestones: Milestone 2, Milestone 3 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants