Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videos with rotation metadata can result in corrupt markup #1503

Closed
jrobble opened this issue Mar 21, 2022 · 0 comments
Closed

Videos with rotation metadata can result in corrupt markup #1503

jrobble opened this issue Mar 21, 2022 · 0 comments
Assignees
@jrobble
Labels
bug
Projects
OpenMPF: Development
Milestone
Milestone 2

Comments

@jrobble
Copy link
Member

jrobble commented Mar 21, 2022 •
edited

Markup will attempt to generate marked-up video files by using the ROTATION value in the media metadata so that the frames are correctly oriented. The size of the output frames must be specified when setting up the ffmpeg pipe. Currently, this size is not taking the ROTATION value into account, which can result in trying to write frames of one size to a pipe that expects a different size.
@jrobble jrobble added the bug label Mar 21, 2022
@jrobble jrobble added this to the Milestone 2 milestone Mar 21, 2022
@jrobble jrobble self-assigned this Mar 21, 2022
@jrobble jrobble added this to To do in OpenMPF: Development via automation Mar 21, 2022
@jrobble jrobble moved this from To do to In Progress in OpenMPF: Development Mar 21, 2022
This was referenced Mar 23, 2022
Merged
Merged
@jrobble jrobble closed this as completed Jul 19, 2022
OpenMPF: Development automation moved this from In Progress to Closed Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrobble jrobble

Labels
bug
Projects
OpenMPF: Development
  
Closed
Milestone
Milestone 2
Development

No branches or pull requests
1 participant
@jrobble