Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenCV 4.5.5 #1519

Open
brosenberg42 opened this issue Apr 22, 2022 · 1 comment
Open

Upgrade to OpenCV 4.5.5 #1519

brosenberg42 opened this issue Apr 22, 2022 · 1 comment

Comments

@brosenberg42
Copy link
Member

Certain corrupt media files can cause Workflow Manager to crash. Upgrading OpenCV allows Workflow Manager to detect the corrupt video and prevent further processing.

@jrobble
Copy link
Member

jrobble commented Apr 26, 2022

We determined that although most Python components have opencv-python>=4.4.0, that is sufficient to allow OpenCV to detect the corrupt video that motivated the C++ OpenCV upgrade to 4.5.5.

Specifically, the earliest match is opencv-python==4.4.0.40 and that fails to read the frame w/o crashing.

Linking to different ffmpeg libraries also fixes the issue. We saw that when @brosenberg42 determined the Ubuntu version of the OpenMPF WFM detects the issue.

Most likely, the Python version of OpenCV is linking to a different version of ffmpeg, while allows it detect the issue although it's an older version of OpenCV.

@brosenberg42 brosenberg42 moved this from In Progress to Testing in OpenMPF: Development May 6, 2022
@brosenberg42 brosenberg42 moved this from Testing to Closed in OpenMPF: Development May 6, 2022
@jrobble jrobble modified the milestones: Milestone 2, Milestone 3 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants