Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image artifacts retain some permissions from the source file #544

Open
jrobble opened this issue Apr 19, 2018 · 0 comments
Open

Image artifacts retain some permissions from the source file #544

jrobble opened this issue Apr 19, 2018 · 0 comments

Comments

@jrobble
Copy link
Member

jrobble commented Apr 19, 2018

The artifact generated for image jobs (one file per image) start with permissions of the source file. This is because we copy the original image over to the artifact location. Those permissions are then masked by the "mpf" umask. To be clear, when I say "masked" I mean that permissions are removed from the file that don't appear in the umask. I ran a test locally and verified this is the case.

This can result in some of the image artifacts having executable permissions. To avoid this, we should ensure that the artifact file permissions start as 0666 (rw-rw-rw-).

@jrobble jrobble added this to the Milestone 3 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant