BUG: image.create_mask now returns ImageBase #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image.create_mask() function now returns an ImageBase rather than a bare ndarray, so that it can be more easily saved with the transform etc. In addition, the ImageBase class is modified to always copy the transform during initialisation, to avoid accidentally overwriting the transforms for parents during any modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image.create_mask() function now returns an ImageBase rather than
a bare ndarray, so that it can be more easily saved with the transform
etc. In addition, the ImageBase class is modified to always copy the
transform during initialisation, to avoid accidentally overwriting the
transforms for parents during any modification.