Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error due to Autocomplete types #104

Closed
CarlosNZ opened this issue Jun 8, 2022 · 5 comments
Closed

Compile error due to Autocomplete types #104

CarlosNZ opened this issue Jun 8, 2022 · 5 comments
Labels
bug Something is borken front-end Front-end related

Comments

@CarlosNZ
Copy link
Contributor

CarlosNZ commented Jun 8, 2022

If you do a full compile (without the "since HEAD") on main you get this error:

@openmsupply-client/inventory: ../common/src/ui/components/inputs/Autocomplete/Autocomplete.tsx(110,7): error TS2322: Type 'boolean' is not assignable to type 'undefined'.

In Autocomplete.tsx:
Screen Shot 2022-06-08 at 3 52 29 PM

Seems like an issue with Material-UI, but odd that it hasn't come up before.

@CarlosNZ CarlosNZ added bug Something is borken front-end Front-end related labels Jun 8, 2022
@CarlosNZ
Copy link
Contributor Author

This seems to have gone away since merging the f/e dependency updates #56

👍

@CarlosNZ
Copy link
Contributor Author

Aaaand, it's back (in feature branch)!

@CarlosNZ CarlosNZ reopened this Jun 20, 2022
@andreievg
Copy link
Collaborator

@CarlosNZ do you think it's still an issue ?

@mark-prins
Copy link
Collaborator

not getting it in the feature branch now..
lerna run --scope @openmsupply-client/* --parallel tsc

@CarlosNZ
Copy link
Contributor Author

Seems like it's sorted. For now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken front-end Front-end related
Projects
None yet
Development

No branches or pull requests

3 participants