Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patented algorithms column in OpenSource SfM list? #36

Closed
wzel opened this issue Jan 30, 2020 · 4 comments
Closed

Patented algorithms column in OpenSource SfM list? #36

wzel opened this issue Jan 30, 2020 · 4 comments

Comments

@wzel
Copy link
Contributor

wzel commented Jan 30, 2020

I think it would make sense to include information which software support evading the patented feature detection and matching algorithms, either by offering a choice of alternative algorithms (actually, none of the six does that, if I'm not wrong; OpenCV does!) or accepting pre-computed data as an additional input (colmap and OpenMVG seem to be capable of that).

@pmoulon
Copy link
Member

pmoulon commented Feb 1, 2020

  • Sift patent should expire soon.

OpenMVG, OpenSfM have natively multiple alternatives to SIFT for matching.
See here for OpenMVG: https://github.com/openMVG/openMVG/blob/develop/src/software/SfM/main_ComputeFeatures.cpp#L98
We also have other method implemented but not yet connected to the SfM pipelinehttps://github.com/openMVG/openMVG/tree/develop/src/openMVG/features

As you said OpenMVG and Colmap are flexible and can ingest anything.
OpenMVG also provide a demo to integrate any OpenCV feature detector here https://github.com/openMVG/openMVG/blob/develop/src/software/SfM/main_ComputeFeatures_OpenCV.cpp#L61

Did were you thinking to other patents?

@wzel
Copy link
Contributor Author

wzel commented Feb 3, 2020

Thanks for all the interesting info. I took notice of the -m option, but then discovered that it only accepted "SIFT".

In addition to SIFT, there's also SURF, which comes with similar restrictions.

@pmoulon
Copy link
Member

pmoulon commented Feb 3, 2020

The -m option accepts 4 possibilities (SIFT, SIFT_ANATOMYY, AKAZE_MLDB, AKAZE_LIOP) and then you can plug any of your own feature using the abstraction that is in place.

@wzel
Copy link
Contributor Author

wzel commented Feb 5, 2020

I must have missed that. Thanks.

@wzel wzel closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants