Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focal length in pixel calculation. #2282

Closed
kundu03 opened this issue Jan 10, 2024 · 4 comments
Closed

Focal length in pixel calculation. #2282

kundu03 opened this issue Jan 10, 2024 · 4 comments

Comments

@kundu03
Copy link

kundu03 commented Jan 10, 2024

Good Morning @pmoulon, currently i am studying OPenMVG library and i came across a problem like what if my drone is not there in the database. Then, I came across your formula for focal_pixel = 1.2 * max(width,height). When i am testing the data for GoPro 10, focal_pixel by this formula is 4800 and the value calculated from the sensor_width given in database is 1153.9708080322662. So, I want to know does it make some problems in future or not.

@pmoulon
Copy link
Member

pmoulon commented Jan 10, 2024

Hi.
Do note that the formula is an approximation for an opening of 90 degree. A GoPro is a fish eye lens and so that's why you note a difference. See here #669 (comment)

@kundu03
Copy link
Author

kundu03 commented Jan 11, 2024

Thank you @pmoulon

@kundu03
Copy link
Author

kundu03 commented Jan 12, 2024

Hi @pmoulon , i have one more doubt. Can you please tell how we can give custom keypoints so that we can have our required number of features.

@pmoulon
Copy link
Member

pmoulon commented Jan 15, 2024

Custom key point can be provided by filling .feat and match files

@kundu03 kundu03 closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants