Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary warning about nested-ness from mxCompare #20

Closed
tbates opened this issue Apr 4, 2017 · 3 comments
Closed

unnecessary warning about nested-ness from mxCompare #20

tbates opened this issue Apr 4, 2017 · 3 comments

Comments

@tbates
Copy link
Member

tbates commented Apr 4, 2017

mxCompare is the preferred way to see an AIC comparison of models. But mxCompare now warns users to use AIC comparison... Can we remove this warning? Or establish who wants to be warned about this?

mxCompare(m2, m1) # ADE is better
  base comparison ep minus2LL   df      AIC    diffLL diffdf  p
1  ADE       <NA>  4 9658.230 3851 1956.230        NA     NA NA
2  ADE        ACE  4 9659.215 3851 1957.215 0.9849158      0 NA
Warning message:
In collectStatistics(nextBaseSummary, nextCompareSummary) :
  Model 'ADE' has the same degrees of freedom as ACE which means the models are not nested and should not be compared with the likelihood ratio test. Compare these models using the information criteria statistics
@jpritikin
Copy link
Member

jpritikin commented Apr 4, 2017 via email

@tbates
Copy link
Member Author

tbates commented Apr 5, 2017

Just setting the p-value to NA (as it happening) is plenty of warning to people, without any other information.

I would just not print the warning at all. The only candidates for being helped by it are new-users, who are instead terrified by it, unnecessarily.

Definitely don't put fake numbers in for Δ-2ll: Much to easy to misinterpret as factual.

The difference often is far from zero (which is what drives the AICs apart). It's only the p-value which we wish to direct people away from, and this is set to NA (used to be a very small actual value like 5e-17 or so)

@jpritikin
Copy link
Member

Fixed in v2.7.9-72-g1ff36c605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants