Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-brnn_merge is unused in the code? #69

Closed
donglixp opened this issue Jun 18, 2017 · 2 comments
Closed

-brnn_merge is unused in the code? #69

donglixp opened this issue Jun 18, 2017 · 2 comments
Assignees
@srush

Comments

@donglixp
Copy link
Contributor

-brnn_merge: Merge action for the bidirectional hidden states: [concat|sum]

I searched the -brnn_merge flag in the code, but it seems that this function has not been implemented.

Thanks!
@srush
Copy link
Contributor

srush commented Jul 3, 2017

Noted. This option will be implemented.

@srush srush self-assigned this Jul 3, 2017
@srush
Copy link
Contributor

srush commented Jul 5, 2017

Added to feature list.

@srush srush closed this as completed Jul 5, 2017
marcotcr pushed a commit to marcotcr/OpenNMT-py that referenced this issue Sep 20, 2017
@jaseweston
New ParlAI logo in the README file (OpenNMT#69)
c9554b9 
* logo in README

* changed to non-offset logo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srush srush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srush @donglixp