Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md out of date? #80

Closed
epwalsh opened this issue Jun 27, 2017 · 2 comments
Closed

README.md out of date? #80

epwalsh opened this issue Jun 27, 2017 · 2 comments

Comments

@epwalsh
Copy link
Contributor

epwalsh commented Jun 27, 2017

At the end of the README under "Not yet implemented", it says "Multi-GPU". However it seems multi-gpu support was added: https://github.com/OpenNMT/OpenNMT-py/blob/master/train.py#L368

Is this correct?
@guillaumekln
Copy link
Contributor

Yes it was implemented by @bmccann a while back. Thanks!

@jekbradbury
Copy link

It was implemented, but the PyTorch nn.DataParallel module that it uses is not very efficient for complicated RNN-heavy networks, so it didn't provide very good scaling. Soon, nn.DistributedDataParallel will be available (I think it's in master already) and could be a better choice (even for one machine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guillaumekln @epwalsh @jekbradbury