Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

About character-aware model #24

Closed
helson73 opened this issue Dec 22, 2016 · 5 comments
Closed

About character-aware model #24

helson73 opened this issue Dec 22, 2016 · 5 comments
Assignees

Comments

@helson73
Copy link

Hi, thanks for releasing such a beautiful toolkit !
This library seems like follow https://github.com/harvardnlp/seq2seq-attn,
however compare to seq2seq-attn, cnn-based character-aware encoder is not available.
Is there any plan to add such feature(cnn) in the future?

@srush
Copy link
Contributor

srush commented Dec 22, 2016

We don't have plans to do this in the short-term, as it complicates the input and output formatting. An alternative approach is to use subword encodings like BPE which can be wrapped around the whole system. We will release tools to do this in the near future, but in the mean time there are several that exist online (https://github.com/vteromero/byte-pair-encoding)

@srush
Copy link
Contributor

srush commented Dec 22, 2016

Actually looks like BPE is coming very soon: in this PR #27

@helson73
Copy link
Author

helson73 commented Dec 22, 2016

@srush Thanks, unfortunately in my language pair, applying BPE is not convenient.
I just implemented it myself, and also advanced Bayesian dropout,
A Theoretically Grounded Application of Dropout in Recurrent Neural Networks and still tuning.
I am wondering why don't add this version of dropout? Paper above reports better performance than current Zaremba's dropout.
I found it can be implemented in a very simple way. Just rewrite nn.Dropout to force noise be fixed during all time steps, and tie noise tensors between clones, and also edit LSTM.lua to apply dropout to all nodes which feed to nn.Linear Nodes. I will share the result when the exp is complete.

@srush
Copy link
Contributor

srush commented Dec 22, 2016

We would love a pull request for either!

@srush
Copy link
Contributor

srush commented Dec 23, 2016

(added as feature request in the forum http://forum.opennmt.net/)

@srush srush closed this as completed Dec 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants