Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out whether ODPCompiler should be stateless or not #11

Closed
jesse-gallagher opened this issue Mar 30, 2018 · 1 comment
Closed

Figure out whether ODPCompiler should be stateless or not #11

jesse-gallagher opened this issue Mar 30, 2018 · 1 comment
Labels
enhancement New feature or request odpcompiler ODP compiler implementation and servlet

Comments

@jesse-gallagher
Copy link
Member

Right now, the design of the class half uses member properties and half passes around active state in compile(). It's not the end of the world as it is, but it should pick a side.
@jesse-gallagher jesse-gallagher added enhancement New feature or request odpcompiler ODP compiler implementation and servlet labels Mar 30, 2018
@jesse-gallagher
Copy link
Member Author

It almost definitely shouldn't, because it'll eventually be used when working against a live NSF, keeping the compiler classpath in memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request odpcompiler ODP compiler implementation and servlet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jesse-gallagher