Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with build_proto.py #46

Closed
Leeful opened this issue May 13, 2020 · 1 comment
Closed

Problem with build_proto.py #46

Leeful opened this issue May 13, 2020 · 1 comment

Comments

@Leeful
Copy link

Leeful commented May 13, 2020

in lines 41, 47 and 94 the reference to 'false' should be 'False'
If false does not start with a capital F python will throw a NameError.
@RetroGamer74
Copy link

You're completely right my friend.
It works with your fix.

Al-Azif added a commit that referenced this issue May 13, 2020
@Al-Azif
false to False for build_proto.py #46 via @Leeful
2978f50
@Al-Azif Al-Azif mentioned this issue May 13, 2020
Merged
kiwidoggie added a commit that referenced this issue May 14, 2020
@kiwidoggie
Merge pull request #49 from OpenOrbis/Al-Azif-build-proto
85471e0 
false to False for build_proto.py #46 via @Leeful
@Al-Azif Al-Azif closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Leeful @Al-Azif @RetroGamer74