-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE credentials part of 'createOffer' generated offer #181
Comments
Currently the IceGatherer starts gathering upon construction. Since IceGatherer.getLocalParameters would be needed to form an offer, this does create a problem with emulating createOffer. Separately, there has been a proposal to add a .gather() method to the IceGatherer that would presumably control the gathering behavior, and this might be another reason to go in that direction. |
Here is the text in the JSEP draft (https://tools.ietf.org/html/draft-ietf-rtcweb-jsep) that refers to ICE candidate gathering. As described below, the onicecandidate callback does not fire until after setLocalDescription() is called. However a pool of ICE candidates can be gathered before then. So a question is whether the behavior described below could be provided by constructing an IceGatherer (to provide for an ICE candidate pool) but not setting the onlocalcandidate callback in ORTC API until after setLocalDescription() is called. 3.4.4. ICE Candidate Pool JSEP applications typically inform the browser to begin ICE gathering When setLocalDescription is eventually called, and the browser goes One example of where this concept is useful is an application that |
Do you mean that the browser should always behave as if the application, at createOffer, always "ask[ed] the browser to gather a pool of potential ICE candidates to help ensure rapid media setup."? |
Question posted to IETF RTCWEB mailing list: |
Justin and EKR's reply: |
I've been told that one ambition for ORTC is to be able to underpin the WebRTC 1.0 API.
Part of that is that the offer created by calling createOffer should include local ICE credentials, but createOffer should not start any ICE gathering.
In ORTC it seems that local ICE credentials are to be fetched from an RTCIceGatherer object, but it is not clear to me if that object stars gathering immediately (if so that would be a problem with "createOffer not start any gathering").
Just raising this issue in case this has been overlooked - I may well be misunderstanding ORTC APIs (or the ambition to be able to underpin WebRTC 1.0).
The text was updated successfully, but these errors were encountered: