New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCRtpSender not checking media track state or identity constraints in constructor #468
Comments
Correct, these same checks in the constructor need to happen as if it was done via setTrack. |
There is no mention of peerIdentity constraints in Media Capture and Streams: Also, IncompatibleMediaStreamTrackError appears to have been removed from WebRTC 1.0: |
It is still there, check 10.4 http://w3c.github.io/webrtc-pc/#isolated-media-streams
|
From webrtc 1.0:
So no, it would not throw an exception. It just would not transmit. |
WebRTC 1.0 Section 5.1.2 says: "All other tracks that are not accessible to the application must not be sent to the peer, with silence (audio), black frames (video) or equivalently absent content being sent in place of track content." So yes, I think that is correct. |
My recommendation:
If the |
I think it is always better to yield an error than fail silently. Anyway, the same behavior shall be consistent across the three methods (constructor,setMediaTrack,setTransport). |
@murillo128 convince 1.0 guys of this and we will follow their lead. |
@robin-raymond I have enough trying to convince you ;) I am fine to whatever 1.0 says |
Closing, this needs to be taken up in the WebRTC Working Group as per my recent message to the mail list: |
When an RTCRtpSender is created, the following error conditions should be checked (as in the setTrack and setTransport methods)
The text was updated successfully, but these errors were encountered: