Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all dictionary defaults vs unsets #514

Closed
robin-raymond opened this issue Apr 25, 2016 · 1 comment
Closed

Check all dictionary defaults vs unsets #514

robin-raymond opened this issue Apr 25, 2016 · 1 comment
Labels
1.0 compatibility issue PR exists publication-blocker

Comments

@robin-raymond
Copy link
Contributor

Not all the defaults look right, not all "unsets" are right. Some "null" references when it should be unset. Double check everything.
@robin-raymond
Copy link
Contributor Author

Also check for nullable vs optional params to all methods / constructors.

@aboba aboba self-assigned this Jul 13, 2016
aboba added a commit that referenced this issue Oct 26, 2016
@aboba
Optional/required attributes in RTCIceCandidate
c7517c1 
Fix for Issue #608

Related to Issue #514
@aboba aboba mentioned this issue Oct 26, 2016
Merged
aboba added a commit that referenced this issue Feb 21, 2018
@aboba
Update of default and required dictionary behavior
3be0e46 
Fix for Issue #514
@aboba aboba mentioned this issue Feb 21, 2018
Merged
@aboba aboba closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 compatibility issue PR exists publication-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond