Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another round of SBC checking validation #107

Closed
wlandau opened this issue May 20, 2024 · 2 comments
Closed

Another round of SBC checking validation #107

wlandau opened this issue May 20, 2024 · 2 comments
Assignees
Labels

Comments

@wlandau
Copy link
Collaborator

wlandau commented May 20, 2024

The package has undergone many changes since I last ran the pipeline for https://openpharma.github.io/brms.mmrm/articles/sbc.html. In particular, the package now supports different correlation structures and different distributional parameter structures for sigma. We might need to cover these cases as new simulation scenarios. We might be able to make the computation easier with:

  • non-subgroup
  • no missing responses
  • no nuisance covariates
  • few treatment groups

We should probably have at least 4 time points.

I don't think we need to run informative prior archetypes through this because that is a data specification problem and the unit tests cover it well.

@wlandau wlandau self-assigned this May 20, 2024
@wlandau wlandau added order: 5 and removed order: 4 labels May 20, 2024
@wlandau
Copy link
Collaborator Author

wlandau commented May 31, 2024

Branch https://github.com/openpharma/brms.mmrm/tree/107 has an updated version of the pipeline in vignettes/sbc/. It seems to be working for a small number of simulations. Currently running it at scale. Should be done by around Monday if everything goes well.

@wlandau
Copy link
Collaborator Author

wlandau commented Jun 1, 2024

Fixed in #110

@wlandau wlandau closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant