Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain errors from the function or optimizer evaluation should be caught #311

Closed
danielinteractive opened this issue Jul 10, 2023 · 3 comments · Fixed by #313
Closed

Certain errors from the function or optimizer evaluation should be caught #311

danielinteractive opened this issue Jul 10, 2023 · 3 comments · Fixed by #313
Assignees
Labels
bug Something isn't working SP2
Milestone

Comments

@danielinteractive
Copy link
Collaborator

danielinteractive commented Jul 10, 2023

Motivation: For small data sets e.g. certain optimizers might fail with error messages. However, other optimizers might still succeed.

Problem: Currently fit_single_optimizer will return any errors from optimizers directly as errors, without filtering.

Solution idea:
When calling h_record_all_output() we could add certain errors in the remove list or similar mechanism, such that convergence is signalled as failed, however the user would not directly get the error but the search for other optimizers to converge could proceed.

Examples:

  • L-BFGS-B needs finite values of 'fn'
  • NA/NaN Hessian evaluation
@danielinteractive danielinteractive added this to Issue To start in mmrm package board via automation Jul 10, 2023
@danielinteractive danielinteractive added bug Something isn't working SP2 labels Jul 10, 2023
@danielinteractive danielinteractive added this to the v0.3 milestone Jul 10, 2023
@danielinteractive danielinteractive self-assigned this Jul 10, 2023
@danielinteractive danielinteractive moved this from Issue To start to Issue In progress in mmrm package board Jul 10, 2023
@Dominic7227
Copy link

Hi Daniel, I also encountered the same issue. Basically the error message reported by one certain optimizer, such as L-BFGS-B, ends up the computing without trying other optimizers, even when I specified multiple optimizer using mmrm_control. Do you happen to know how to tackle with this? Many thanks!

@danielinteractive
Copy link
Collaborator Author

Hi @Dominic7227 , yeah we are working on the fix right now, see the corresponding PR which is in flight

@Dominic7227
Copy link

That is so much appreciated!

BTW, the current solution that works for me is to put L-BFGS-B (the error reporting optimizer) at the end of optimizer list when specified into mmrm_control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SP2
Projects
Development

Successfully merging a pull request may close this issue.

2 participants