Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: convert will attempt to find format in target package #10

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

dgkf
Copy link
Collaborator

@dgkf dgkf commented Jul 7, 2023

Closes #7

@dgkf dgkf linked an issue Jul 7, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #10 (c9a231a) into main (9960ddc) will increase coverage by 5.74%.
The diff coverage is 80.00%.

❗ Current head c9a231a differs from pull request most recent head c62b7a2. Consider uploading reports for the commit c62b7a2 to get more accurate results

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   77.15%   82.89%   +5.74%     
==========================================
  Files          11       11              
  Lines         372      345      -27     
==========================================
- Hits          287      286       -1     
+ Misses         85       59      -26     
Impacted Files Coverage Δ
R/tag_typed.R 40.62% <0.00%> (+16.89%) ⬆️
R/convert.R 95.58% <100.00%> (ø)
R/convert_re.R 100.00% <100.00%> (ø)
R/state_config.R 94.28% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dgkf dgkf merged commit f95be2e into main Jul 7, 2023
7 checks passed
@dgkf dgkf deleted the 7-convert branch July 7, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert() would be nicer if it picked up the format from DESCRIPTION
1 participant