Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the response to according to the language setting. #1

Open
geeklog opened this issue Nov 30, 2023 · 3 comments
Open

Modify the response to according to the language setting. #1

geeklog opened this issue Nov 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@geeklog
Copy link
Collaborator

geeklog commented Nov 30, 2023

Currently, the response is set to Chinese. Please modify the response language according to the language setting in the user settings panel.

@geeklog geeklog added the bug Something isn't working label Nov 30, 2023
@xiangtianyu
Copy link
Collaborator

xiangtianyu commented Nov 30, 2023

Actually, we check the language setting before we append the language prompt

if (LanguageSettingsState.getInstance().getLanguageIndex() == 1) {

@geeklog
Copy link
Collaborator Author

geeklog commented Dec 1, 2023

My apologies for overlooked this. But there should be an additional '\n' before the language prefix, i.e. "\nRespond in Chinese". Additionally, it is debatable whether using a magic number 1 as the language indicator is a good idea. Perhaps the code should be refactored to provide a more comprehensive solution, such as a different flow to handle the language part of the prompt.

@xiangtianyu
Copy link
Collaborator

We may change the language settings to enums later

@xiangtianyu xiangtianyu added enhancement New feature or request and removed bug Something isn't working labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants